From: Debayan Sutradhar <debayansutradhar3@gmail.com>
Date: Mon, 07 Jun 2021 08:23:15 +0530
Subject: Merge pull request #48 from quimodotcom/master
---
Merge pull request #48 from quimodotcom/master

optimised code
---


--- 'a/openfile/src/main/java/com/stream_pi/documentopen/DocumentOpen.java'
+++ /dev/null
@@ -1,73 +0,0 @@
-package com.stream_pi.documentopen;
-
-import com.stream_pi.action_api.actionproperty.property.ControlType;
-import com.stream_pi.action_api.actionproperty.property.FileExtensionFilter;
-import com.stream_pi.action_api.actionproperty.property.Property;
-import com.stream_pi.action_api.actionproperty.property.Type;
-import com.stream_pi.action_api.externalplugin.NormalAction;
-import com.stream_pi.util.exception.MinorException;
-import com.stream_pi.util.alert.StreamPiAlert;
-import com.stream_pi.util.alert.StreamPiAlertType;
-import com.stream_pi.util.version.Version;
-
-import java.io.File;
-import java.awt.*;
-import java.net.URI;
-
-public class DocumentOpen extends NormalAction
-{
-
-    public DocumentOpen()
-    {
-        setName("Document Open");
-        setAuthor("quimodotcom");
-        setHelpLink("https://github.com/stream-pi/essentialactions");
-        setVersion(new Version(1,0,0));
-
-        setCategory("Essentials");
-
-    }
-
-    @Override
-    public void initProperties() throws Exception {
-        //Called First
-
-        Property property1 = new Property("documentopen", Type.STRING);
-        property1.setDefaultValueStr("Document.pdf");
-        property1.setControlType(ControlType.FILE_PATH);
-        property1.setDisplayName("Document File Location");
-        property1.setExtensionFilters(
-                new FileExtensionFilter("pdf","*.pdf"),
-                new FileExtensionFilter("docx", "*.docx")
-        );
-
-        addClientProperties(
-                property1
-        );
-    }
-
-
-    @Override
-    public void initAction()  {
-
-    }
-
-    public String path = null;
-
-    @Override
-    public void onActionClicked() throws MinorException
-    {
-        Property documentloc = getClientProperties().getSingleProperty("documentopen");
-
-        if (documentloc.getStringValue().isBlank())
-        {
-            throw new MinorException("No file specified");
-            return;
-        }
-
-        File file = new File(documentloc.getStringValue());
-
-        //Open PDF file
-        Desktop.getDesktop().open(file);
-    }
-}

--- /dev/null
+++ b/openfile/src/main/java/com/stream_pi/openfile/OpenFile.java
@@ -0,0 +1,81 @@
+package com.stream_pi.openfile;
+
+import com.stream_pi.action_api.actionproperty.property.ControlType;
+import com.stream_pi.action_api.actionproperty.property.FileExtensionFilter;
+import com.stream_pi.action_api.actionproperty.property.Property;
+import com.stream_pi.action_api.actionproperty.property.Type;
+import com.stream_pi.action_api.externalplugin.NormalAction;
+import com.stream_pi.util.exception.MinorException;
+import com.stream_pi.util.alert.StreamPiAlert;
+import com.stream_pi.util.alert.StreamPiAlertType;
+import com.stream_pi.util.version.Version;
+
+import java.io.File;
+import java.awt.*;
+import java.net.URI;
+import java.io.IOException;
+
+public class OpenFile extends NormalAction
+{
+
+    public OpenFile()
+    {
+        setName("Open Files");
+        setAuthor("quimodotcom");
+        setHelpLink("https://github.com/stream-pi/essentialactions");
+        setVersion(new Version(1,0,0));
+        setServerButtonGraphic("fas-folder-open");
+        setCategory("Essentials");
+
+    }
+
+    @Override
+    public void initProperties() throws MinorException {
+        //Called First
+
+        Property property1 = new Property("openfile", Type.STRING);
+        property1.setDefaultValueStr("*.*");
+        property1.setControlType(ControlType.FILE_PATH);
+        property1.setDisplayName("Document File Location");
+        property1.setExtensionFilters(
+                new FileExtensionFilter("File","*.*")
+        );
+
+        addClientProperties(
+                property1
+        );
+    }
+
+
+    @Override
+    public void initAction()  {
+
+    }
+
+    public String path = null;
+
+    @Override
+    public void onActionClicked() throws MinorException
+    {
+        try {
+            showfile();
+          }
+          catch(IOException e) {
+            e.printStackTrace();
+          }
+    }
+    public void showfile() throws MinorException, IOException
+    {
+        Property fileloc = getClientProperties().getSingleProperty("openfile");
+
+        if (fileloc.getStringValue().isBlank())
+        {
+            throw new MinorException("No file specified");
+        }
+
+        File file = new File(fileloc.getStringValue());
+
+        Desktop.getDesktop().open(file);
+    }
+
+}

--- 'a/openfile/src/main/java/module-info.java'
+++ b/openfile/src/main/java/module-info.java
@@ -1,4 +1,4 @@
-module com.stream_pi.documentopen
+module com.stream_pi.openfile
 {
     requires com.stream_pi.action_api;
     requires org.kordamp.ikonli.javafx;