From: Debayan Sutradhar <debayansutradhar3@gmail.com>
Date: Mon, 31 May 2021 22:48:08 +0530
Subject: [Media Key Action] Updated according to new standards
---
[Media Key Action] Updated according to new standards
---


--- 'a/mediakeyaction/pom.xml'
+++ b/mediakeyaction/pom.xml
@@ -6,7 +6,7 @@
 
     <groupId>com.stream-pi</groupId>
     <artifactId>mediakeyaction</artifactId>
-    <version>1.1.0</version>
+    <version>1.1.1</version>
 
     <build>
         <plugins>
@@ -45,9 +45,6 @@
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <maven.compiler.source>11</maven.compiler.source>
         <maven.compiler.target>11</maven.compiler.target>
-
-        <IkonliVersion>11.5.0</IkonliVersion>
-        <IkonliFA5PackVersion>11.5.0</IkonliFA5PackVersion>
     </properties>
 
     <dependencies>
@@ -68,17 +65,5 @@
             <artifactId>javafx-media</artifactId>
             <version>${JavaFXVersion}</version>
         </dependency>
-
-        <dependency>
-            <groupId>org.kordamp.ikonli</groupId>
-            <artifactId>ikonli-fontawesome5-pack</artifactId>
-            <version>${IkonliFA5PackVersion}</version>
-        </dependency>
-
-        <dependency>
-            <groupId>org.kordamp.ikonli</groupId>
-            <artifactId>ikonli-javafx</artifactId>
-            <version>${IkonliVersion}</version>
-        </dependency>
     </dependencies>
 </project>
\ No newline at end of file

--- 'a/mediakeyaction/src/main/java/com/stream_pi/mediakeyaction/MediaKeyAction.java'
+++ b/mediakeyaction/src/main/java/com/stream_pi/mediakeyaction/MediaKeyAction.java
@@ -3,11 +3,13 @@ package com.stream_pi.mediakeyaction;
 import com.stream_pi.action_api.actionproperty.property.Property;
 import com.stream_pi.action_api.actionproperty.property.Type;
 import com.stream_pi.action_api.externalplugin.NormalAction;
+import com.stream_pi.util.exception.MinorException;
 import com.stream_pi.util.platform.Platform;
 import com.stream_pi.util.version.Version;
 
 import java.io.*;
 import java.util.List;
+import java.util.Objects;
 
 public class MediaKeyAction extends NormalAction
 {
@@ -19,11 +21,12 @@ public class MediaKeyAction extends Norm
         setAuthor("rnayabed");
         setServerButtonGraphic("fas-volume-up");
         setHelpLink("https://github.com/stream-pi/essentialactions/tree/master/mediakeyaction");
-        setVersion(new Version(1,1,0));
+        setVersion(new Version(1,1,1));
     }
 
     @Override
-    public void initProperties() throws Exception {
+    public void initProperties() throws MinorException
+    {
         List<String> states = List.of("Play/Pause", "Previous", "Next", "Vol Up", "Vol Down", "Mute", "Stop");
 
         Property mediaKeyTypeProperty = new Property("media_key_type", Type.LIST);
@@ -34,17 +37,27 @@ public class MediaKeyAction extends Norm
     }
 
     @Override
-    public void initAction() throws Exception {
-        if(getServerConnection().getPlatform() == Platform.WINDOWS)
-            extractKeyEXEToTmpDirectory();
+    public void initAction() throws MinorException
+    {
+        try
+        {
+            if(getServerConnection().getPlatform() == Platform.WINDOWS)
+                extractKeyEXEToTmpDirectory();
+        }
+        catch (IOException e)
+        {
+            e.printStackTrace();
+            throw new MinorException("Error","IOException occurred. \n\n"+e.getMessage());
+        }
+
     }
 
     private static String absolutePathToExe;
-    private void extractKeyEXEToTmpDirectory() throws Exception
+    private void extractKeyEXEToTmpDirectory() throws IOException
     {
         String tmpDirectory = System.getProperty("java.io.tmpdir");
 
-        InputStream is = getClass().getResource("key.exe").openStream();
+        InputStream is = Objects.requireNonNull(getClass().getResource("key.exe")).openStream();
         absolutePathToExe = tmpDirectory+"/key.exe";
         File file = new File(absolutePathToExe);
         file.deleteOnExit();
@@ -62,7 +75,7 @@ public class MediaKeyAction extends Norm
     }
 
     @Override
-    public void onActionClicked() throws Exception
+    public void onActionClicked() throws MinorException
     {
         int state = getClientProperties().getSingleProperty("media_key_type").getSelectedIndex();
 
@@ -81,12 +94,6 @@ public class MediaKeyAction extends Norm
         }
     }
 
-    @Override
-    public void onShutDown()
-    {
-
-    }
-
     private void runCommand(String command) throws Exception
     {
         Runtime rt = Runtime.getRuntime();
@@ -94,7 +101,7 @@ public class MediaKeyAction extends Norm
         pr.waitFor();
     }
 
-    private void linuxHandler(int state) throws Exception
+    private void linuxHandler(int state)
     {
         try
         {
@@ -119,7 +126,8 @@ public class MediaKeyAction extends Norm
         }
     }
 
-    private void windowsHandler(int state) throws Exception {
+    private void windowsHandler(int state)
+    {
         try
         {
             String exe = "\""+absolutePathToExe+"\"";